Deadline: Be able to pass Mongo url to job

[iLLiCiTiT]

Brief description

Add option to pass mongo url to deadline job.

Changes

• added attributes pass_mongo_url to CollectDefaultDeadlineServer plugin which is used in submitters to define if OPENPYPE_MONGO environment is passed to job environments

Testing notes:

1. Trigger deadline publishing
2. The job (worker) should not need to have set mongo url in keyring or in global environments

[mkolar]

Task linked: OP-2539 Add openpype mongo environments to deadline

[BigRoy]

The job (worker) should not need to have set mongo url in keyring or in global environments

What's the use case for this? As in, why do we want to pass the mongo URL? Is it just so it doesn't need to be explicitly set on each machine?

We could also do it the other way around and have the default OPENPYPE_MONGO value when not defined in a job set in GlobalJobPreLoad and use it from a setting on the OpenPype Deadline Plug-in. Similar to how OpenPype Executables is collected? (Which can be done without needing the ingest that into jobs using an Event Plug-in as shown in #2605). Not saying that is better - but just throwing it out there. Actually, that might be less useful. On the off chance that a single studio runs against multiple OpenPype databases (e.g. OP 2 vs 3 or maybe some other means of splitting things up in completely different setups) but use a single Deadline database then moving it to Deadline Plug-in settings would actually be less useful. I guess allowing to pass it with the job is our best bet then.

---

Also, these code changes really want me to offload the actual deadline submission into its own library function for the Deadline module, just so we have more code re-use across all plug-ins instead of needing to keep them in sync like this, copying and pasting the code to all of them.

[mkolar]

What's the use case for this? As in, why do we want to pass the mongo URL? Is it just so it doesn't need to be explicitly set on each machine?

Exactly, there is a solid pushback against setting them on machines on a few client sites, so this should make it more flexible.

[mkolar]

Also, these code changes really want me to offload the actual deadline submission into its own library function for the Deadline

very true. @antirotor didn't you start working on that some time ago?

[antirotor]

very true. @antirotor didn't you start working on that some time ago?

yes but just bits and pieces. Nothing definitive and I agree that it must be done

[kalisp]

I think there should be context.data.get and not context.get , at least according to my testing.
If not, please revert commit, if this fix is ok, just dismiss review and re-request.