Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

General: FFmpeg conversion also check attribute string length #2635

Conversation

iLLiCiTiT
Copy link
Member

Brief description

Conversion for ffmpeg is also checking length of string stored in exr attributes because ffmpeg has limit up to 8196 characters.

Changes

  • information about input file from oiiotool are loaded using xml format
    • this gives more and more precise information about input
  • all attributes with string values longer than 8196 are removed from exr to be able pass it to ffmpeg
  • few smaller tweaks of oiiotool conversion
    • oiiotool loads only channels that are used for output so works a little bit faster with reducing memory leak issues
    • function for converting does not require frame start/env arguments

Testing notes:

  1. Try publish exrs with string attributes which have value longer than 8196 characters (e.g. cryptomatte stores whole manifest)
  2. It should be able to create review and thumbnail just fine

@mkolar
Copy link
Member

mkolar commented Feb 2, 2022

@iLLiCiTiT iLLiCiTiT self-assigned this Feb 2, 2022
@iLLiCiTiT iLLiCiTiT added the type: enhancement Enhancements to existing functionality label Feb 2, 2022
Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes issue with testing .exr

@iLLiCiTiT iLLiCiTiT merged commit c49f7e4 into develop Feb 9, 2022
@iLLiCiTiT iLLiCiTiT deleted the OP-2573_Multilayer-exrs-conversion-does-not-work-all-the-time branch February 9, 2022 16:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants