Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Settings: Implementation for search in settings #2699

Merged
merged 7 commits into from
Feb 22, 2022

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Feb 11, 2022

Brief description

A prototype for #2697

Press CTRL+F to open the search UI. Note that it is just a prototype. Might crash, have ugly code - just to show that it could work! (Probably CMD+F on Mac)

Current state:

2022-02-11.17-21-40.mp4

return []


class RecursiveSortFilterProxyModel(QtCore.QSortFilterProxyModel):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RecursiveSortFilterProxyModel can be imported from openpype.tools.utils.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct. But - this is a changed one. This filters to ALL columns and actually uses Qt 5.10+ feature to enable recursive filtering that Qt allows. Since I assumed the Settings tool would never be used in older Qt (e.g. in hosts with older Python, etc.)

In essence this class name should just be updated to match what it does instead - but I couldn't think of a good name. Maybe FilterAllColumnsProxyModel?

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
@BigRoy
Copy link
Collaborator Author

BigRoy commented Feb 22, 2022

Thanks for the changes. Works for me! ✅

@iLLiCiTiT iLLiCiTiT marked this pull request as ready for review February 22, 2022 12:48
Copy link
Member

@iLLiCiTiT iLLiCiTiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for me.

@iLLiCiTiT iLLiCiTiT merged commit b43b304 into ynput:develop Feb 22, 2022
@BigRoy
Copy link
Collaborator Author

BigRoy commented Feb 23, 2022

@iLLiCiTiT should we maybe make the search case insensitive? :) Currently JPEG or jpeg doesn't find Jpeg for example.

@iLLiCiTiT
Copy link
Member

Currently JPEG or jpeg doesn't find Jpeg for example.

Oh, sh*t, Yes!

@iLLiCiTiT
Copy link
Member

Created PR #2810

@BigRoy BigRoy deleted the settings_search branch March 20, 2024 15:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants