Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Settings UI: Search case sensitivity #2810

Merged
merged 3 commits into from
Feb 25, 2022
Merged

Settings UI: Search case sensitivity #2810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c83016
search is not case sensitive
iLLiCiTiT Feb 25, 2022
c7c324c
text change timer is singleshot
iLLiCiTiT Feb 25, 2022
1574a24
fix crashed entity creation handling
iLLiCiTiT Feb 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion openpype/tools/settings/settings/categories.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,7 +715,12 @@ def _update_labels_visibility(self):
self._outdated_version_label,
self._require_restart_label,
}
if self.entity.require_restart:
if self.is_modifying_defaults or self.entity is None:
require_restart = False
else:
require_restart = self.entity.require_restart

if require_restart:
visible_label = self._require_restart_label
elif self._is_loaded_version_outdated:
visible_label = self._outdated_version_label
Expand Down
3 changes: 2 additions & 1 deletion openpype/tools/settings/settings/search_dialog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def filterAcceptsRow(self, row, parent):
regex = self.filterRegExp()
if not regex.isEmpty() and regex.isValid():
pattern = regex.pattern()
compiled_regex = re.compile(pattern)
compiled_regex = re.compile(pattern, re.IGNORECASE)
source_model = self.sourceModel()

# Check current index itself in all columns
Expand Down Expand Up @@ -75,6 +75,7 @@ def __init__(self, parent):

filter_changed_timer = QtCore.QTimer()
filter_changed_timer.setInterval(200)
filter_changed_timer.setSingleShot(True)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch. :)


view.selectionModel().selectionChanged.connect(
self._on_selection_change
Expand Down