This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
WebPublisher: Fix wrong number of frames for video file #2851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith ffprobe Previously wrong hardcoded value was used. This implementation needs to be monitored for weird format of published video files.
64qam
approved these changes
Mar 8, 2022
kalisp
deleted the
bugfix/OP-2860_Nuke-loader---loading-mp4-from-web-publisher-incorrect-duration
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Wrong value 0-1 was hardcoded, now
ffprobeis used to try get frame count from a fileDescription
In the case of any weird video format, fallback to values stored in DB (Ftrack) is used.
Testing notes: