Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

General: Removed silo references and terminal splash #2927

Merged
merged 4 commits into from
Mar 22, 2022

Conversation

iLLiCiTiT
Copy link
Member

Brief description

Silo is not used in OpenPype for a long time and still there are references to it in the code. Also there is terminal splash which is not used anymore and can be removed.

Description

All references to silo were removed in the code with few deprecated comments related to it. Removed terminal splash was used at first versions of OpenPype 3 but is not used because of huge amount of lines added to stdout. Also reduced Loader tool logic related to roots which is now simplified so library loader logic does not need LibrarySubsetWidget anymore.

Changes

  • removed silo references from code
  • removed terminal_splash.py and splash.txt from openpype/lib
  • Loader tool is not using registered_root but Anatomy.roots based on current project in context

Testing notes:

  1. Both loader and library loader should work when copying source of version
  2. Everything else should work as expected (all removed code was not used)

@iLLiCiTiT iLLiCiTiT self-assigned this Mar 22, 2022
@iLLiCiTiT iLLiCiTiT added the type: refactor Structural changes not affecting functionality label Mar 22, 2022
@antirotor
Copy link
Member

I will mourn the removal of animated splash even if it wasn't used. R.I.P. ✝️

@iLLiCiTiT iLLiCiTiT added this to the next milestone Mar 22, 2022
@iLLiCiTiT iLLiCiTiT merged commit bbb12d2 into develop Mar 22, 2022
@iLLiCiTiT iLLiCiTiT deleted the enhancement/removed_unused_code branch March 22, 2022 13:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: refactor Structural changes not affecting functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants