Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

General: OIIO conversion for ffmeg can handle sequences #2958

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

iLLiCiTiT
Copy link
Member

Brief description

Sequences now convert input into one output file so there are missing file and first frame contains last frame.

Description

The bug is that output filepath uses filename of input without frame indexing (%04d) so oiio will output to same file. This was changed and filename is created like tmp.%04d.exr.

Changes

  • add filename with frame indexing when converting sequence for ffmpeg

Testing notes:

  1. Run publish which produce sequence that must be converted for ffmpeg
  2. Publish should finish successfully (or not crash due to missing frames)

Resolves #2957

@iLLiCiTiT iLLiCiTiT self-assigned this Mar 28, 2022
@iLLiCiTiT iLLiCiTiT added the type: bug Something isn't working label Mar 28, 2022
@antirotor
Copy link
Member

Strange thing is that I am now unable to force openpype to create sequence that needs to be processed by OIIO. With cryptomattes, all I get from ExtractReview plugin is:

Unsupported compression on input files. Skipping !!!

problem is probabably that cryptomattes are reported by ffprobe as having 0 width and 0 height?

All and all, I can't easily test it now.

@iLLiCiTiT
Copy link
Member Author

Do you know which compression is used? We catch only DWAA and DWAB.

@antirotor
Copy link
Member

antirotor commented Mar 29, 2022

Do you know which compression is used? We catch only DWAA and DWAB.

This is the output of ffprobe:

{
2022-03-29 14:34:28:  0: STDOUT:     "programs": [
2022-03-29 14:34:28:  0: STDOUT:     ],
2022-03-29 14:34:28:  0: STDOUT:     "streams": [
2022-03-29 14:34:28:  0: STDOUT:         {
2022-03-29 14:34:28:  0: STDOUT:             "index": 0,
2022-03-29 14:34:28:  0: STDOUT:             "codec_name": "exr",
2022-03-29 14:34:28:  0: STDOUT:             "codec_long_name": "OpenEXR image",
2022-03-29 14:34:28:  0: STDOUT:             "codec_type": "video",
2022-03-29 14:34:28:  0: STDOUT:             "codec_tag_string": "[0][0][0][0]",
2022-03-29 14:34:28:  0: STDOUT:             "codec_tag": "0x0000",
2022-03-29 14:34:28:  0: STDOUT:             "width": 0,
2022-03-29 14:34:28:  0: STDOUT:             "height": 0,
2022-03-29 14:34:28:  0: STDOUT:             "coded_width": 0,
2022-03-29 14:34:28:  0: STDOUT:             "coded_height": 0,
2022-03-29 14:34:28:  0: STDOUT:             "closed_captions": 0,
2022-03-29 14:34:28:  0: STDOUT:             "has_b_frames": 0,
2022-03-29 14:34:28:  0: STDOUT:             "level": -99,
2022-03-29 14:34:28:  0: STDOUT:             "refs": 1,
2022-03-29 14:34:28:  0: STDOUT:             "r_frame_rate": "25/1",
2022-03-29 14:34:28:  0: STDOUT:             "avg_frame_rate": "25/1",
2022-03-29 14:34:28:  0: STDOUT:             "time_base": "1/25",
2022-03-29 14:34:28:  0: STDOUT:             "disposition": {
2022-03-29 14:34:28:  0: STDOUT:                 "default": 0,
2022-03-29 14:34:28:  0: STDOUT:                 "dub": 0,
2022-03-29 14:34:28:  0: STDOUT:                 "original": 0,
2022-03-29 14:34:28:  0: STDOUT:                 "comment": 0,
2022-03-29 14:34:28:  0: STDOUT:                 "lyrics": 0,
2022-03-29 14:34:28:  0: STDOUT:                 "karaoke": 0,
2022-03-29 14:34:28:  0: STDOUT:                 "forced": 0,
2022-03-29 14:34:28:  0: STDOUT:                 "hearing_impaired": 0,
2022-03-29 14:34:28:  0: STDOUT:                 "visual_impaired": 0,
2022-03-29 14:34:28:  0: STDOUT:                 "clean_effects": 0,
2022-03-29 14:34:28:  0: STDOUT:                 "attached_pic": 0,
2022-03-29 14:34:28:  0: STDOUT:                 "timed_thumbnails": 0
2022-03-29 14:34:28:  0: STDOUT:             }
2022-03-29 14:34:28:  0: STDOUT:         }
2022-03-29 14:34:28:  0: STDOUT:     ],
2022-03-29 14:34:28:  0: STDOUT:     "chapters": [
2022-03-29 14:34:28:  0: STDOUT:     ],
2022-03-29 14:34:28:  0: STDOUT:     "format": {
2022-03-29 14:34:28:  0: STDOUT:         "filename": "C:/projects/ondra_playground/999_abc/999_abc_0010/work/lighting/renders/maya/OPG_999_abc_0010_workfileLighting_v067/Main\\Main_Cryptomatte.1001.exr",
2022-03-29 14:34:28:  0: STDOUT:         "nb_streams": 1,
2022-03-29 14:34:28:  0: STDOUT:         "nb_programs": 0,
2022-03-29 14:34:28:  0: STDOUT:         "format_name": "exr_pipe",
2022-03-29 14:34:28:  0: STDOUT:         "format_long_name": "piped exr sequence",
2022-03-29 14:34:28:  0: STDOUT:         "size": "1895931",
2022-03-29 14:34:28:  0: STDOUT:         "probe_score": 51
2022-03-29 14:34:28:  0: STDOUT:     }
2022-03-29 14:34:28:  0: STDOUT: }

Copy link
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even as I cannot directly test it, I believe the code is sound.

@iLLiCiTiT iLLiCiTiT merged commit b040c95 into develop Mar 31, 2022
@iLLiCiTiT iLLiCiTiT deleted the bugfix/sequence_conversion_for_ffmpeg branch March 31, 2022 09:44
@mkolar mkolar added this to the next milestone Apr 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conversion of sequence by OIIO tools for ffmpeg
3 participants