This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 129
Maya: Render Creator has configurable options. #3097
Merged
antirotor
merged 106 commits into
develop
from
enhancement/OP-2040_Maya_Render_creator-should-have-configurable-options
Aug 1, 2022
Merged
Maya: Render Creator has configurable options. #3097
antirotor
merged 106 commits into
develop
from
enhancement/OP-2040_Maya_Render_creator-should-have-configurable-options
Aug 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… renderman independent of its versions
…or and potentially other things. - Leave it up to validators to ensure the output matches what the user wanted it to match so we can never submit wrong renders.
- This is a first step to allow the default render settings to be applied from elsewhere. - Also simplifies the logic of the actual Creator
…0_Maya_Render_creator-should-have-configurable-options-
…0_Maya_Render_creator-should-have-configurable-options
So I have a scene where I've set Maya Hardware 2.0 renderer. When I create render instance, I get this error:
I think we should just create the instance, not trying to do anything clever :) |
ghost
requested a review
from antirotor
August 1, 2022 07:29
m-u-r-p-h-y
suggested changes
Aug 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Traceback (most recent call last):
File "D:\REPO\OpenPype\openpype\tools\creator\window.py", line 432, in _on_create
data={"variant": variant}
File "D:\REPO\OpenPype\openpype\pipeline\create\legacy_create.py", line 148, in legacy_create
plugin = Creator(name, asset, options, data)
File "D:\REPO\OpenPype\openpype\hosts\maya\plugins\create\create_render.py", line 91, in __init__
lib_rendersettings.RenderSettings().set_default_renderer_settings()
File "D:\REPO\OpenPype\openpype\hosts\maya\api\lib_rendersettings.py", line 95, in set_default_renderer_settings
self._set_redshift_settings(width, height)
File "D:\REPO\OpenPype\openpype\hosts\maya\api\lib_rendersettings.py", line 162, in _set_redshift_settings
cmds.setAttr("redshiftOptions.imageFormat", img_ext)
RuntimeError: setAttr: Error reading data element number 1: exr
ghost
requested a review
from m-u-r-p-h-y
August 1, 2022 12:21
m-u-r-p-h-y
approved these changes
Aug 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
antirotor
approved these changes
Aug 1, 2022
antirotor
deleted the
enhancement/OP-2040_Maya_Render_creator-should-have-configurable-options
branch
August 1, 2022 16:16
This was referenced Mar 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Adds configurable render options in the settings. Resolves #2282.
Description
Adds schema specified render options to be triggered through the settings instead of hard-coded render options in the render creator plugins.
Additional info
The intent is to have the configurable options grabbed through a function that's within the render creator class, and that will append the settings by being triggered within the render creator function that sets the renderer settings.