This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Webpublisher: replace space by underscore in subset names #3160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses Setting to replace invalid characters automatically. Creates valid subset name and renames layer.
Uses Setting to replace invalid characters automatically. Creates valid subset name and renames layer.
Layer name validator was looking into wrong field. Layer name should follow same naming convention as subset name to see relation between subset name and layer name better. Introduced clean_name property returning layer name without publishing highlight icons.
64qam
approved these changes
May 10, 2022
kalisp
deleted the
bugfix/develop_OP-3137_Webpublisher-replace-space-by-underscore-in-subset-names
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Invalid character(s) (as a underscore) triggered error in ValidateNaming plugin.
Description
Plugin which creates instances from color coded layers uses
ValidateNamingSettings to clean subset and layer nameDevelop version of #3159
Testing notes:
project_settings/photoshop/publish/CollectColorCodedInstances