This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug description
submission of publishing job to deadline had a serious bug for some quite time: It is creating new instances based on stuff that is being rendered. For this it is using some skeleton data that are part of every newly created instance.
When the instance was being created, it
copy()
the skeleton data but that is only shallow copy. Anything that was modifying data on newly created instance edited them in skeleton data too, influencing all other newly created instances.Test case:
This will result in:
All instances have
FOO
even if we expect ony C instance to have it.This PR is solving it by changing
copy()
todeepcopy()