Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Project manager: Sped up project load #3216

Merged
merged 2 commits into from
May 19, 2022
Merged

Conversation

iLLiCiTiT
Copy link
Member

Brief description

Speed of project loading was enhanced by ignoring signals during initial project item creation.

Description

Blocking of signals during that time cause that filtering and repaint of view is not triggered which makes everything much smoother. Also refresh button forces to refresh current project.

Testing notes:

  1. Open project manager
  2. Select project
  3. Load of project entities should be 3x faster

@iLLiCiTiT iLLiCiTiT requested review from 64qam, BigRoy and kalisp May 19, 2022 13:11
@iLLiCiTiT iLLiCiTiT self-assigned this May 19, 2022
@iLLiCiTiT iLLiCiTiT added the type: enhancement Enhancements to existing functionality label May 19, 2022
@BigRoy
Copy link
Collaborator

BigRoy commented May 19, 2022

Testing this here now - but it doesn't appear much faster on my end. The only side effect after this PR is that now it doesn't show the "Working..." overlay anymore and thus it feels like it's hanging more than before.

Correction. This PR is making it lightspeed compared to what it was before. Thank you very much!

@iLLiCiTiT
Copy link
Member Author

The only side effect after this PR is that now it doesn't show the "Working..." overlay anymore and thus it feels like it's hanging more than before.

Project manager never had that overlay?

@iLLiCiTiT iLLiCiTiT merged commit 592c74f into develop May 19, 2022
@iLLiCiTiT iLLiCiTiT deleted the bugfix/project_manager_speed branch May 19, 2022 14:19
@BigRoy
Copy link
Collaborator

BigRoy commented May 19, 2022

This PR has introduced a bug where the Tools column doesn't show the correct data visually until when double clicked and editable.

After

What I'm seeing on refresh (note the empty line compared to the next screenshot):
afbeelding

When double clicking the tools for a specific asset
afbeelding

Before

afbeelding


Note also how the table view doesn't show all the editable columns. I have a hunch that maybe delegates aren't being registered correctly?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants