Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Flame: debugging #3224

Merged
merged 56 commits into from
May 30, 2022
Merged

Flame: debugging #3224

merged 56 commits into from
May 30, 2022

Conversation

jakubjezek001
Copy link
Member

@jakubjezek001 jakubjezek001 commented May 20, 2022

Brief description

Few bugs related to timing were fixed

Description

Clips were not holding correct frame ranges. Retimes were not correctly transferred to exported data and db.

Additional info

  • added retiming data to otio exporter
  • handles and frameranges are now passed correctly to otio
  • fix thumbnail frame correctly set
  • fixing end handles were shorter
  • fixing multiple clilps from one source with gaps
  • fixing multiple clips from one source
  • adding togge to creator for include handles

Known issue

  • when not enough of material in head clip is reframed at strart if Sequence Publish preset is used in exporter

- to be able match collection if sequence with holes
- also make code more explicit about input arguments
removing frame range input form reference
@ynbot
Copy link
Contributor

ynbot commented May 20, 2022

Task linked: OP-3191 Flame: publishing bugs

@jakubjezek001 jakubjezek001 added host: Flame Autodesk Flame integration type: bug Something isn't working labels May 20, 2022
jakubjezek001 and others added 11 commits May 26, 2022 14:25
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Copy link
Member

@iLLiCiTiT iLLiCiTiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks Ok. But it would be good if someone also tries the publishing intself, at least in Hiero.

@jakubjezek001 jakubjezek001 merged commit 2197817 into develop May 30, 2022
@mkolar mkolar deleted the bugfix/OP-3191_Flame-publishing-bugs branch June 9, 2022 07:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Flame Autodesk Flame integration type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants