This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Maya: reference loaders could store placeholder in referenced url #3264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…variable.
Useful for remote workflows where Site Sync is being used.
When Load reference is used, real root value (c:/project) is replaced with ${OPENPYPE_ROOT_WORK}.
All inheriting plugins implementing shared method. Flag 'use_env_var_as_root' set to True for testing temporarily, proper location in Setting should be decided.
kalisp
added
type: enhancement
|
Task linked: OP-3277 Maya environment variables loader |
BigRoy
reviewed
May 30, 2022
Comment on lines
+54
to
+56
| file_url = self.prepare_root_value(self.fname, | ||
| context["project"]["code"]) | ||
| nodes = cmds.file(file_url, |
There was a problem hiding this comment.
Somehow it looks to me like this particular change - if applicable to all references should actually happen in the ReferenceLoader class in load and potentially just do self.fname = self.prepare_root_value(self.fname).
Just so the logic is encapsulated to that area only?
We should be able to make that change ONLY in the ReferenceLoader class and have that work for all implementations already, right?
There was a problem hiding this comment.
Imho no, each inheriting class of ReferenceLoader could calculate file url differently (or at least some existing loaders do). Plus we sometimes need it in update logic.
Configured via Maya/Maya-dirmap to use in all Loaders
mkolar
reviewed
May 31, 2022
openpype/settings/entities/schemas/projects_schema/schema_project_maya.json
Outdated
Show resolved
Hide resolved
openpype/settings/entities/schemas/projects_schema/schema_project_maya.json
Outdated
Show resolved
Hide resolved
…ect_maya.json Co-authored-by: Milan Kolar <mkolar@users.noreply.github.com>
…ect_maya.json Co-authored-by: Milan Kolar <mkolar@users.noreply.github.com>
m-u-r-p-h-y
approved these changes
Jun 1, 2022
|
It is working on a farm too. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
All reference loaders in Maya now could instead of real published folder use environment variable placholder. This would allow to use this workfile in different locations (remote artist computer, studio etc.)
Description
OPENPYPE_PROJECT_ROOT_WORKis calculated for values in Anatomy or overridden values from Local Setting.This placeholder is physically stored in workfile, each value is resolved when workfile is opened.
This allows remote artists to reference assets in a workfile and publish it. Same workfile will then work everywhere (studio, different artist) if they have Anatomy or Local Setting configured to existing folder on their machine.
This limits opening workfiles without Openpype, this could be remedied by adding used environment variable to artist environment. (By adding to theirs mel script??)
Additional info
Flag to trigger this behavior is hardcoded to True for testing. Placement of this toggle in Settings need to be decided.
Easiest option is to add it as a plugin variable, this would mean add/modify this behavior on each plugin separately. Usage of
environment variable could be also widened to not only Maya. It could be used in any host which stores full path of referenced files in its workfile metadata. In that case, more general location to enable/disable this behavior should be chosen.
Testing notes: