This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
SiteSync: speedup of starting process #3280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setSortable forces refresh itself
Do creation of settings only in Thread as it is expensive operation.
Let only thread do it, expensive operation potentially.
Default is true, is not persistent between opening of dialog.
mkolar
approved these changes
Jun 7, 2022
It makes sending of project name to model clearer.
64qam
suggested changes
Jun 9, 2022
64qam
approved these changes
Jun 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Enabled Site Sync increased loading time of Tray and manipulations in Loader quite significantly on slow (Mongo on Cloud) connection.
Description
Most expensive operation is to get all Site Sync enabled projects as its pulling project settings for all projects. This was moved into thread, so it is not blocking start. (For specific customer with cloud Mongo stationed far away
get_project_settingstakes about 3 seconds :/)Currently this check is being done on every loop (to start syncing as soon as project is enabled), if this would be problematic, resolving this only once Tray session would need to be implemented.
Testing notes: