deadline: fixing misidentification of revieables

openpype/modules/deadline/plugins/publish/submit_publish_job.py

@@ -643,9 +643,6 @@ def _get_representations(self, instance, exp_files):
  def _solve_families(self, instance, preview=False):
  families = instance.get("families")
 
- # test also instance data review attribute
- preview = preview or instance.get("review")
-
  # if we have one representation with preview tag
  # flag whole instance for review and for ftrack
  if preview:
@@ -725,10 +722,17 @@ def process(self, instance):
  " This may cause issues."
  ).format(source))
 
- families = ["render"]
+ family = "render"
+ if "prerender" in instance.data["families"]:
+ family = "prerender"
+ families = [family]
+
+ # pass review to families if marked as review
+ if data.get("review"):
+ families.append("review")
 
  instance_skeleton_data = {
- "family": "render",
+ "family": family,
  "subset": subset,
  "families": families,
  "asset": asset,
@@ -750,15 +754,6 @@ def process(self, instance):
  "useSequenceForReview": data.get("useSequenceForReview", True)
  }
 
- if "prerender" in instance.data["families"]:
- instance_skeleton_data.update({
- "family": "prerender",
- "families": []})
-
- # also include review attribute if available
- if "review" in data:
- instance_skeleton_data["review"] = data["review"]
-
  # skip locking version if we are creating v01
  instance_version = instance.data.get("version") # take this if exists
  if instance_version != 1: