-
Notifications
You must be signed in to change notification settings - Fork 129
Maya: Handle excluding model
family from frame range validator.
#3370
Conversation
Task linked: OP-2449 Maya: Validate Frame Range |
model
family from frame range validator.model
family from frame range validator.
This doesn't seem like a 'clean fix' and feels rather arbitrary? How come the Sounds like something that points to another potential deeper issue? Should the "review" family actually be on the model's 'instance'? Aren't we now mixing data of the Review instance and Model instance (or other reviewable instances)? |
There are a few problems in play here. Most would be solved by implementing the new publisher in Maya, so we wouldn't have to hack the whole review system, however, that is just constantly slipping in priorities :(. @BigRoy is right and this is not just an issue with model, but anything that get's nested under a review set inside maya. Right now, it really poses two questions.
For 1. I'd say that the review framerange should be propagated to the model (or other nested instance) so that it can be properly validated, if required. as for 2. we should probably just expose the families attribute to settings, so the studio can choose not to validate frameranges on a set of families for themselves. |
This sounds unwanted since it opens up for motion/multiple time samples to make it's way into the model
Good question. I personally think it's not necessarily only a Shot validation. Maybe at best the Project Manager could also have a state where start/end frame is NOT SET like a boolean stating "use frame range". |
True, however, I'm not sure it's worth doing it in v3 data model now. In v4 there is differentiation between asset types and they can technically have empty values on attributes, which will make this a lot easier.
Also a very good point. But in that case the only option we have now to make it at least functional is to skip validation on certain families which is exactly what this PR attempts. I just think those families should be configurable |
@@ -27,6 +27,7 @@ class ValidateFrameRange(pyblish.api.InstancePlugin): | |||
"yeticache"] | |||
optional = True | |||
actions = [openpype.api.RepairAction] | |||
exclude_families = ["model"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we add this to settings, we'll solve the production situation right now and can focus on doing it properly as Roy suggests in v4
Or could we reverse that logic? Only check |
Hmm... to add to it there seems to be probem with Repair Action for render instances (as it is running against non-existent instances in Maya - they are created on-the-fly by collector). Maybe repair action should run only on those instances that are "physically" present in Maya and have frame range attributes. |
This is a bit limited to pyblish capabilities right now it's checking in |
Move default families. Co-authored-by: Ondřej Samohel <33513211+antirotor@users.noreply.github.com>
…m/pypeclub/OpenPype into OP-2449/Maya-Validate-Frame-Range
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's the whole point of the PR. to not validate on models ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh. I was reading the original Description and was expecting something else.
In this case it works as expected :)
Brief description
This resolves #2562 by excluding the
model
and some other families from having theirframeStart
andframeEnd
attributes validated (which they wouldn't have because of their being geometry).Description
The
validate_frame_range.py
currently validates the incorrect subset for published Review instances when there's a nestedmodel
subset in it. This fix bypasses the validator checks when it detects the families are ofmodel
instance, and some others.Testing notes:
model
instance.review
instance.