Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Nuke: Collect representation files based on Write #3407

Merged
merged 2 commits into from
Jun 24, 2022

Conversation

iLLiCiTiT
Copy link
Member

Brief description

Collect output frames based on Write node file input field instead of guessing based on files in output directory.

Description

Using previous approach expected that output folder contains only output from current state of the write node but didn't handle previous renders with different frame range or different output extensions. New approach is using nuke api to collect all possible output files from write node based on it's current state by evaluating path with each possible frame.

This change fixed bug/removed feature - it is NOT possible that more frames is integrated then Write node has defined with frame start and frame end.
Example: Write node would render 1001-1010, but I could manually hit Render Local and render 999-1020. In that case were integrated frames 999-1020, that is not possible now.

Testing notes:

Render family

  1. Launch Nuke
  2. Create render instance
  3. Hit local render and change frame range that extends frame start or frame end
  4. Publish
  5. Only expected frame range is integrated
    image

Still frame

  1. Launch Nuke
  2. Create Still image instance
  3. Render output of created write node
  4. Change settings of CreateWriteStill plugin in project_anatomy/imageio/nuke/nodes/requiredNodes/ to use different extension
  5. Remove previous write node
  6. Create again Still image instance with same variant as in step 2.
  7. Hit publish
  8. Integration should not fail

@ynbot
Copy link
Contributor

ynbot commented Jun 24, 2022

Task linked: OP-3351 Nuke still image representation fix

@iLLiCiTiT iLLiCiTiT added type: bug Something isn't working host: Nuke labels Jun 24, 2022
@iLLiCiTiT iLLiCiTiT self-assigned this Jun 24, 2022
@iLLiCiTiT iLLiCiTiT merged commit 1a1d9ec into develop Jun 24, 2022
@iLLiCiTiT iLLiCiTiT deleted the bugfix/OP-3351_Nuke-still-image-representation-fix branch June 24, 2022 14:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Nuke type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants