This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Windows installer: Clean old files and add version subfolder #3445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement
This PR is addressing issue where old files were left when OP version was reinstalled to the same folder. This has one important effect - this will currently delete all files there without any remorse (deleting any user stuff that might be there).
I've also added version subfolder to the path so OpenPype will install to
C:\Program Files (x86)\OpenPype\3.12.1-nightly.1This is in preparation for implementing #3415
Testing instructions
.\tools\build_win_installer.ps1to create installer.Resolve #3440