Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Migrate basic families to the new Tray Publisher #3469

Merged

Conversation

mkolar
Copy link
Member

@mkolar mkolar commented Jul 5, 2022

This move all the families that don't require a custom collector from standalone publisher to the new Tray publisher GUI. This is a first step in getting rid of the old standalone publisher.

Testing should be as easy as running the tray publisher from the OpenPype tray menu and trying to publish some families that are available by default.

This is really just a change in the default settings, to have some reasonable defaults.

@mkolar mkolar self-assigned this Jul 5, 2022
@mkolar mkolar added the type: enhancement Enhancements to existing functionality label Jul 5, 2022
@ynbot
Copy link
Contributor

ynbot commented Jul 5, 2022

Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested render family only with exr sequence and mov file. EXR was not able to finish the publishing at all. It was freezed on integrate new plugin at coppying temp files process.

Mov file was showing review toggle on but it was not adding it into instance data so no reviewable was generated.

@iLLiCiTiT
Copy link
Member

Not sure how much of these issues are related to this PR :)

Mov file was showing review toggle on but it was not adding it into instance data so no reviewable was generated.

This looks like a bug of the collector plugin.

Tested render family only with exr sequence and mov file. EXR was not able to finish the publishing at all. It was freezed on integrate new plugin at coppying temp files process.

This is strange, but again not related to this PR.

Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested these:
Screenshot 2022-07-12 113846

Seems to work fine.

@mkolar
Copy link
Member Author

mkolar commented Jul 12, 2022

Tested render family only with exr sequence and mov file. EXR was not able to finish the publishing at all. It was freezed on integrate new plugin at coppying temp files process.

Mov file was showing review toggle on but it was not adding it into instance data so no reviewable was generated.

Was that publishing both at the same time as two representations or two individual publishes? I managed to publish just fine.

@mkolar mkolar dismissed jakubjezek001’s stale review July 13, 2022 07:39

We just found that is actually problem in the publisher itself. Fix is coming in another PR

@mkolar mkolar merged commit 5f62dc4 into develop Jul 13, 2022
@mkolar mkolar deleted the feature/OP-3435_New-Publisher-convert-basic-set-of-families branch July 13, 2022 07:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants