Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Nuke: double slate #3521

Merged
merged 6 commits into from
Jul 22, 2022
Merged

Nuke: double slate #3521

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
de0c0ef
reencode with concat, fix audio
Jul 15, 2022
b5d7ae0
no need to copy codec and pixel format
Jul 15, 2022
78b4bba
add continuos arguments next to each other
iLLiCiTiT Jul 22, 2022
f99f811
add `-y` into base of ffmpeg arguments
iLLiCiTiT Jul 22, 2022
6d573c9
Merge branch 'develop' into bugfix/OP-3520_Nuke-double-slate
jakubjezek001 Jul 22, 2022
abc5c9e
adding codec args for keeping continuity even wtih audio stream.
jakubjezek001 Jul 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 27 additions & 24 deletions openpype/plugins/publish/extract_review_slate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,36 +285,32 @@ def process(self, instance):
audio_channels,
audio_sample_rate,
audio_channel_layout,
input_frame_rate
)

# replace slate with silent slate for concat
slate_v_path = slate_silent_path

# create ffmpeg concat text file path
conc_text_file = input_file.replace(ext, "") + "_concat" + ".txt"
conc_text_path = os.path.join(
os.path.normpath(stagingdir), conc_text_file)
_remove_at_end.append(conc_text_path)
self.log.debug("__ conc_text_path: {}".format(conc_text_path))

new_line = "\n"
with open(conc_text_path, "w") as conc_text_f:
conc_text_f.writelines([
"file {}".format(
slate_v_path.replace("\\", "/")),
new_line,
"file {}".format(input_path.replace("\\", "/"))
])

# concat slate and videos together
# concat slate and videos together with concat filter
# this will reencode the output
if input_audio:
fmap = [
"[0:v] [0:a] [1:v] [1:a] concat=n=2:v=1:a=1 [v] [a]",
"-map", '[v]',
"-map", '[a]'
]
else:
fmap = [
"[0:v] [1:v] concat=n=2:v=1:a=0 [v]",
"-map", '[v]'
]
concat_args = [
ffmpeg_path,
"-y",
"-f", "concat",
"-safe", "0",
"-i", conc_text_path,
"-c", "copy",
"-i", slate_v_path,
"-i", input_path,
"-filter_complex",
]
concat_args.extend(fmap)
if offset_timecode:
concat_args.extend(["-timecode", offset_timecode])
# NOTE: Added because of OP Atom demuxers
Expand All @@ -328,19 +324,25 @@ def process(self, instance):
copy_args = (
"-metadata",
"-metadata:s:v:0",
"-codec:v",
"-pixfmt",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Args for codec and pixfmt should be filled same way as here https://github.com/pypeclub/OpenPype/pull/3521/files#diff-1064edbd703275fe1bdff4855b452f266ceef997f708712a16a9a21740653a68R186

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the link working?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Args for codec and pixfmt are actually not needed. The bitrate is.

Copy link
Member

@iLLiCiTiT iLLiCiTiT Jul 18, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the link working?

Seems like it's not. There is format_args and codec_args calculated from source (approximately line 186). That must be used as source for codec and pixfmt instead.

They actually must be filled otherwise ffmpeg will use default values for the codec and format.

The same applies for format. For example if mxf OPAtom would be processed without that arguments output won't be OPAtom but default mxf profile defined by ffmpeg.

"-b:v",
"-b:a",
)
args = source_ffmpeg_cmd.split(" ")
for indx, arg in enumerate(args):
if arg in copy_args:
concat_args.append(arg)
# assumes arg has one parameter
concat_args.append(args[indx + 1])
concat_args.append("-y")
# add final output path
concat_args.append(output_path)

# ffmpeg concat subprocess
self.log.debug(
"Executing concat: {}".format(" ".join(concat_args))
"Executing concat filter: {}".format
(" ".join(concat_args))
)
openpype.api.run_subprocess(
concat_args, logger=self.log
Expand Down Expand Up @@ -488,9 +490,10 @@ def _create_silent_slate(
audio_channels,
audio_sample_rate,
audio_channel_layout,
input_frame_rate
):
# Get duration of one frame in micro seconds
items = audio_sample_rate.split("/")
items = input_frame_rate.split("/")
if len(items) == 1:
one_frame_duration = 1.0 / float(items[0])
elif len(items) == 2:
Expand Down