Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

General: Get current context document functions #3522

Merged

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Jul 15, 2022

Brief description

Moved function get_asset from openpype.lib.avalon_context into openpype.pipeline.context_tools and renamed to get_current_project_asset. Also was added function get_current_project to receive current project document.

Description

Function in openpype.lib was marked as deprecated and internally is calling the new function in context tools. New function has extended arguments with ability to pass asset id and define fields that will be returned.

Additional information

At some places there is possibility to use different source for asset documents, e.g. during publishing should be asset documents already available on instance or context (marked with TODO).

Testing notes:

Hosts should work as before:

  • Harmony
    • validation of scene settings (workfile publishing)
  • Hiero
    • clip loader
  • Houdini
    • fps should be set correctly based on asset data
  • Maya
    • scene settings should be set on workfile open
    • validation of fps
    • creation of render
  • Nuke
    • workfiles settings (not sure how to trigger?)
    • validation of scene (workfile publishing)
  • Resolve
    • load clip
  • StandalonePublisher
    • editorial publishing
  • Unreal
    • load layout
    • load animation

@ynbot
Copy link
Contributor

ynbot commented Jul 15, 2022

@iLLiCiTiT iLLiCiTiT added the type: refactor Structural changes not affecting functionality label Jul 15, 2022
@iLLiCiTiT iLLiCiTiT self-assigned this Jul 15, 2022
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested Hiero, Resolve, Nuke, StandalonePublisher and all worked as expected

Copy link
Contributor

@simonebarbieri simonebarbieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested Unreal and it works correctly.

@mkolar mkolar merged commit 83139c4 into develop Jul 22, 2022
@mkolar mkolar deleted the feature/OP-3592_Get-current-context-document-functions branch July 22, 2022 13:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: refactor Structural changes not affecting functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants