This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e Transaction logic
…as before (rudimentary tested only)
# Conflicts: # openpype/plugins/publish/integrate_new.py
… in CollectAnatomyContextData and CollectAnatomyInstanceData. This currently was duplicated logic and should not be handled in the Integrator
…oser to where it's used
…families variable
…resentation write
- This is moved from the Integrate Asset New settings
iLLiCiTiT
reviewed
Jul 18, 2022
iLLiCiTiT
reviewed
Jul 18, 2022
iLLiCiTiT
reviewed
Jul 18, 2022
iLLiCiTiT
reviewed
Jul 18, 2022
openpype/settings/entities/schemas/projects_schema/schemas/schema_global_publish.json
Outdated
Show resolved
Hide resolved
Modified code:
Explanations (To avoid confusion)
|
It worked on basic published in:
|
…hint where to move the value
iLLiCiTiT
force-pushed
the
feature/refactor_integrator
branch
from
July 22, 2022 07:58
b532a20
to
037ed71
Compare
iLLiCiTiT
approved these changes
Jul 22, 2022
Just fixed the exclusion condition. Ready to merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup PR from #2898 which was merged to an intermediate branch and we've added a few commits.
To be able to merge this, we've moved
hosts
andfamilies
filters for both the old and the new integrator to their respective GUI settings. The names of classes don't help here, but we can't easily rename the original class as we need to keep production backwards compatibility with existing project settings overrides.The settings are here
project_settings/global/publish/IntegrateAssetNew
(the original integrator)project_settings/global/publish/IntegrateAsset
(the refactored integrator)This PR makes all of the hosts and families default to the refactored integrator. The plan is to merge do develop and look out for any issues that appear while testing any other PRs or production deployments. As soon as an issue appears, that particular combination of host and family should be moved to the legacy integrator in the settings. That action will revert it to the original and won't affect production, however, it will also automatically start generating a list of problematic combinations that need to be addressed in further PRs on the path to eradicate the old and ugly integrator plugin.
Please make sure that before you deploy develop, or next minor release into production, someone has the rights to quickly change system settings on these two plugins in case of any production issues.
Instructions for fixing issues cause by this PR
If something breaks during integration, you can hotfix it by editing the exclusion filters in settings
project_settings/global/publish/IntegrateAsset
.You can exclude any combination of
host + family
and at from that moment the legacy integrator will be used instead. This should allow you to fix any problems cause on the spot without even restarting your DCC. If you need to do this at any point, please make sure to report thehost + family
combination to us, so it can be looked at.This change will make it into the next patch release, considering it can be reverted selectively and doesn't need a new build.