Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Update to Python 3.9 #3546

Merged
merged 24 commits into from
Oct 20, 2022
Merged

Update to Python 3.9 #3546

merged 24 commits into from
Oct 20, 2022

Conversation

antirotor
Copy link
Member

Feature

This PR is updating base OpenPype Python to 3.9 to match VFX platform CY2022

Close #3480

@antirotor antirotor added the type: feature Larger, user affecting changes and completely new things label Jul 20, 2022
@antirotor antirotor self-assigned this Jul 20, 2022
@ynbot
Copy link
Contributor

ynbot commented Jul 20, 2022

Task linked: OP-3553 Update Python version to 3.9.x to match VFX platform CY2022

@antirotor antirotor marked this pull request as draft July 20, 2022 17:05
@antirotor
Copy link
Member Author

antirotor commented Jul 20, 2022 •
edited
Loading

first incompatibility:

Traceback (most recent call last):
  File "C:\Users\annat\.pyenv\pyenv-win\versions\3.9.6\lib\threading.py", line 973, in _bootstrap_inner
    self.run()
  File "C:\Users\annat\.pyenv\pyenv-win\versions\3.9.6\lib\threading.py", line 910, in run
    self._target(*self._args, **self._kwargs)
  File "C:\Users\annat\Documents\pype\op-p3.9\openpype\modules\ftrack\tray\ftrack_tray.py", line 207, in set_action_server
    elif not self.thread_socket_server.isAlive():
AttributeError: 'SocketThread' object has no attribute 'isAlive'

as isAlive() was removed in favour of is_alive()

@antirotor antirotor added the Bump Minor Pull requests that update a dependency file label Jul 25, 2022
@antirotor antirotor changed the base branch from develop to release/3.13.x July 25, 2022 12:14
@antirotor
Copy link
Member Author

I believe this is actually testable. Tested in Maya 2020 so far without trouble....

@antirotor antirotor marked this pull request as ready for review August 2, 2022 06:59
@antirotor antirotor requested a review from a team August 2, 2022 07:00
@kalisp
Copy link
Member

kalisp commented Aug 5, 2022

README.md in root needs to be updated too.

@antirotor antirotor changed the base branch from release/3.13.x to release/3.14.x August 12, 2022 10:53
@antirotor antirotor changed the base branch from release/3.14.x to release/3.15.x August 18, 2022 14:57
kalisp
kalisp approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build on Windows went fine.
Tests on AE PS, Nuke too.

@antirotor
Copy link
Member Author

Tested on Centos 7, need tests on Macs

@antirotor
Copy link
Member Author

Should work on macs, tested on virtual Catalina

@64qam 64qam self-requested a review October 18, 2022 14:43
@64qam
Copy link
Member

64qam commented Oct 18, 2022

LGTM

@antirotor antirotor merged commit fdee5d6 into release/3.15.x Oct 20, 2022
@antirotor antirotor deleted the feature/OP-3553_update-to-python-39 branch October 20, 2022 09:50
@antirotor antirotor added this to the next-minor milestone Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iLLiCiTiT iLLiCiTiT iLLiCiTiT left review comments

@kalisp kalisp kalisp approved these changes

@64qam 64qam 64qam approved these changes

Assignees

@antirotor antirotor

Labels
Bump Minor Pull requests that update a dependency file type: feature Larger, user affecting changes and completely new things
Projects
None yet
Milestone
3.15.0
Development

Successfully merging this pull request may close these issues.

Update Python version to 3.9.x to match VFX platform CY2022
6 participants
@antirotor @ynbot @kalisp @64qam @iLLiCiTiT @mkolar