Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Maya: fix Review image plane attribute #3569

Merged
merged 5 commits into from
Jul 26, 2022
Merged

Conversation

moonyuet
Copy link
Member

@moonyuet moonyuet commented Jul 26, 2022

Brief description

Fixing the bug regarding to OP-3356_Maya-Review-Image-plane-attribute

Description

The main issue of this bug is review image plane still showing up as thumbnail in ftrack even when its related attribute (Image Plane) in Maya is turned off.

Solution

Adjust the code in extract_thumbnail.py to tell the system not to create the thumbnail image in the project path of the ftrack

resolves #3272

@ynbot
Copy link
Contributor

ynbot commented Jul 26, 2022

Task linked: OP-3356 Maya: Review Image plane attribute

@mkolar mkolar changed the title bugfix/OP-3356_Maya-Review-Image-plane-attribute Maya: fix Review image plane attribute Jul 26, 2022
@mkolar mkolar added the type: bug Something isn't working label Jul 26, 2022
@mkolar mkolar self-requested a review July 26, 2022 07:21
Copy link
Member

@mkolar mkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Kayla.

I think you might have misunderstood the issue at hand. The problem is that thumbnails always have imageplane visible in them, regardless whether it's turned on or off in on the maya set options.

You are skipping thumbnail creation altogether when ImagePlane option is off, rather than hiding the image plane and still creating the thumbnail. Albeit I will admit that not generating a thumbnail doesn't result in generating a wrong one :) #technicallythetruth

To fix it, you just need to replicate this behaviour of the extract_playblast, which already deals with it correctly .https://github.com/pypeclub/OpenPype/blob/cfc11bb84027635850670f6c99ae67a89faf4b92/openpype/hosts/maya/plugins/publish/extract_playblast.py#L111-L116

@@ -100,6 +100,13 @@ def process(self, instance):
# camera.
if preset.pop("isolate_view", False) and instance.data.get("isolate"):
preset["isolate"] = instance.data["setMembers"]

#Show or Hide Image Plane
image_plane = instance.data.get("imagePlane", True)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trailing whitespace

@@ -100,6 +100,13 @@ def process(self, instance):
# camera.
if preset.pop("isolate_view", False) and instance.data.get("isolate"):
preset["isolate"] = instance.data["setMembers"]

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line contains whitespace

Copy link
Member

@mkolar mkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Works as it should Thank you

@mkolar mkolar merged commit 792c10c into ynput:develop Jul 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maya: Review Image plane attribute
3 participants