Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

General: New Integrator small fixes #3583

Merged
merged 13 commits into from
Jul 28, 2022
Merged

Conversation

iLLiCiTiT
Copy link
Member

Brief description

Fixed few smaller issues in integrator and cleaned up code and comments.

Description

Minimum frame padding is defined by last frame of sequence instead of first frame (999 vs. 1000). Frame padding fom anatomy template is always considered when frame should be filled. Replaced AssertionErrors with KnownPublishError. Added "output" to representation context keys and removed explicit set of it at the end. Make sure that representation context has filled first frame during sequence processing. Removed comments marking logic as backwards compatibility which is still fully required and does not have any replacement.

Testing notes:

  • Integration should work
  • Integrated representation filenames should at all costs have filled frame with padding from anatomy templates or lenght of last frame (in case anatomy templates padding is 4 but last frame is e.g. "10000" - in that case padding should be 5)
    • even if frames of input filepaths have padding of 6

@iLLiCiTiT iLLiCiTiT self-assigned this Jul 27, 2022
@iLLiCiTiT iLLiCiTiT added the type: enhancement Enhancements to existing functionality label Jul 27, 2022
@iLLiCiTiT iLLiCiTiT merged commit 27a4c9c into develop Jul 28, 2022
@iLLiCiTiT iLLiCiTiT deleted the feature/integrate_small_issues branch July 28, 2022 11:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants