This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 129
Photoshop: implemented {layer} placeholder in subset template #3591
Merged
kalisp
merged 9 commits into
develop
from
feature/OP-3283_Allow-subset-template-name-for-manual-Create-in-Photoshop
Aug 1, 2022
+60
−10
Merged
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4379dc0
OP-3283 - implemented proper usage of {layer} in subset template for …
kalisp 8c95aab
OP-3283 - extracted logic to plugin to reuse
kalisp 87cf386
OP-3283 - implemented for new creator
kalisp a03f2b6
OP-3283 - fixed imports
kalisp de8668d
OP-3283 - fix not create separate from multiple selected
kalisp 8318842
OP-3283 - fix without select and multiple
kalisp 90962d6
OP-3283 - refactored logic
kalisp 3b9e485
Merge branch 'develop' of github.com:pypeclub/OpenPype into feature/O…
kalisp 4ac9ed6
OP-3283 - fix invalid characters in subset name
kalisp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,6 +5,10 @@ | |
CreatedInstance, | ||
legacy_io | ||
) | ||
from openpype.hosts.photoshop.api.plugin import ( | ||
get_subset_template, | ||
get_subset_name_for_multiple | ||
) | ||
|
||
|
||
class ImageCreator(Creator): | ||
|
@@ -38,17 +42,24 @@ def create(self, subset_name_from_ui, data, pre_create_data): | |
top_level_selected_items = stub.get_selected_layers() | ||
if pre_create_data.get("use_selection"): | ||
only_single_item_selected = len(top_level_selected_items) == 1 | ||
for selected_item in top_level_selected_items: | ||
if ( | ||
only_single_item_selected or | ||
pre_create_data.get("create_multiple")): | ||
if ( | ||
only_single_item_selected or | ||
pre_create_data.get("create_multiple")): | ||
for selected_item in top_level_selected_items: | ||
if selected_item.group: | ||
groups_to_create.append(selected_item) | ||
else: | ||
top_layers_to_wrap.append(selected_item) | ||
else: | ||
group = stub.group_selected_layers(subset_name_from_ui) | ||
groups_to_create.append(group) | ||
else: | ||
group = stub.group_selected_layers(subset_name_from_ui) | ||
groups_to_create.append(group) | ||
else: | ||
stub.select_layers(stub.get_layers()) | ||
try: | ||
group = stub.group_selected_layers(subset_name_from_ui) | ||
except: | ||
raise ValueError("Cannot group locked Bakcground layer!") | ||
groups_to_create.append(group) | ||
|
||
if not groups_to_create and not top_layers_to_wrap: | ||
group = stub.create_group(subset_name_from_ui) | ||
|
@@ -68,7 +79,12 @@ def create(self, subset_name_from_ui, data, pre_create_data): | |
|
||
if creating_multiple_groups: | ||
# concatenate with layer name to differentiate subsets | ||
subset_name += group.name.title().replace(" ", "") | ||
subset_template = get_subset_template(self.family) | ||
subset_name = get_subset_name_for_multiple(subset_name, | ||
subset_template, | ||
group, | ||
self.family, | ||
data["variant"]) | ||
|
||
if group.long_name: | ||
for directory in group.long_name[::-1]: | ||
|
@@ -143,3 +159,8 @@ def _handle_legacy(self, instance_data): | |
def _clean_highlights(self, stub, item): | ||
return item.replace(stub.PUBLISH_ICON, '').replace(stub.LOADED_ICON, | ||
'') | ||
@classmethod | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. expected 1 blank line, found 0 |
||
def get_dynamic_data( | ||
cls, variant, task_name, asset_id, project_name, host_name | ||
): | ||
return {"layer": ""} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not use bare
except:
, it also catches unexpected events like memory errors, interrupts, system exit, and so on. Preferexcept Exception:
. If you're sure what you're doing, be explicit and writeexcept BaseException:
.do not use bare 'except'