This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
TrayPublisher: Removed from experimental tools #3667
Merged
+4
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is confusing. If we take it out of experimental, we need to at the same time hide the old one and make that optional. Two publishers at the same time is a road to hell I'm afraid. Do we now have 1-1 functionality match? |
There is not 100% but at the same time we should add an easy access to use tray publisher so somebody in production can test what we have there now. We can add standalone publisher and tray publisher into module settings so they can be enabled/disabled. Also we can change label of standalone publisher action. |
|
It is not clear what should happen next. current current |
|
I would remove the old publisher and keep the new one just called |
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last):
File "/usr/local/bin/flake8", line 8, in
sys.exit(main())
File "/usr/local/lib/python3.8/dist-packages/flake8/main/cli.py", line 18, in main
app.run(argv)
File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 393, in run
self._run(argv)
File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 381, in _run
self.run_checks()
File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 300, in run_checks
self.file_checker_manager.run()
File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 331, in run
self.run_serial()
File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 315, in run_serial
checker.run_checks()
File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 598, in run_checks
self.run_ast_checks()
File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 502, in run_ast_checks
for (line_number, offset, text, check) in runner:
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 56, in run
parser.visit(self.tree)
File "/usr/lib/python3.8/ast.py", line 371, in visit
return visitor(node)
File "/usr/lib/python3.8/ast.py", line 379, in generic_visit
self.visit(item)
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 39, in visit_ClassDef
self.capture_issues_visitor('ClassDef', node)
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 33, in capture_issues_visitor
self.generic_visit(node)
File "/usr/lib/python3.8/ast.py", line 381, in generic_visit
self.visit(value)
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 36, in visit_Call
self.capture_issues_visitor('Call', node)
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 30, in capture_issues_visitor
issues = checker.run(node)
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checkers/render.py", line 22, in run
if isinstance(arg, ast.Call) and arg.func.id == 'locals':
AttributeError: 'Attribute' object has no attribute 'id'
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last):
File "/usr/local/bin/flake8", line 8, in
sys.exit(main())
File "/usr/local/lib/python3.8/dist-packages/flake8/main/cli.py", line 18, in main
app.run(argv)
File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 393, in run
self._run(argv)
File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 381, in _run
self.run_checks()
File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 300, in run_checks
self.file_checker_manager.run()
File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 331, in run
self.run_serial()
File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 315, in run_serial
checker.run_checks()
File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 598, in run_checks
self.run_ast_checks()
File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 502, in run_ast_checks
for (line_number, offset, text, check) in runner:
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 56, in run
parser.visit(self.tree)
File "/usr/lib/python3.8/ast.py", line 371, in visit
return visitor(node)
File "/usr/lib/python3.8/ast.py", line 379, in generic_visit
self.visit(item)
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 39, in visit_ClassDef
self.capture_issues_visitor('ClassDef', node)
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 33, in capture_issues_visitor
self.generic_visit(node)
File "/usr/lib/python3.8/ast.py", line 381, in generic_visit
self.visit(value)
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 36, in visit_Call
self.capture_issues_visitor('Call', node)
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 30, in capture_issues_visitor
issues = checker.run(node)
File "/usr/local/lib/python3.8/dist-packages/flake8_django/checkers/render.py", line 22, in run
if isinstance(arg, ast.Call) and arg.func.id == 'locals':
AttributeError: 'Attribute' object has no attribute 'id'
iLLiCiTiT
force-pushed
the
enhancement/tray_publisher_is_not_experimental
branch
from
a6e1fbb
to
5d74883
Compare
…ental # Conflicts: # openpype/hosts/traypublisher/addon.py
|
Standalone publisher is disabled by default (can be enabled) and has label |
64qam
approved these changes
Nov 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Tray publisher is added to tray menu by default and artist don't have to enable the experimental option.
Description
Tray Publisher is now in ready to use state and should work at least the same way as standalone publisher did. We should collect as much input from artists as possible thus the tool is removed from experimental tools and is added as available feature in tray.
Additional information
Changed label to
Tray Publishso it is possible to differentiate in standalone publisher and tray publisher.Testing notes: