Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Loader: Subset groups using client operations #3710

Merged
merged 7 commits into from
Aug 23, 2022
Merged

Loader: Subset groups using client operations #3710

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9c2c111
added notes into client directory
iLLiCiTiT Aug 23, 2022
0d8ab1c
fix unsetting of value
iLLiCiTiT Aug 23, 2022
0f11433
use client options to change subset group
iLLiCiTiT Aug 23, 2022
7f234e1
fix iterator index acces
iLLiCiTiT Aug 23, 2022
4062bf5
print traceback on crashed dynamic thread
iLLiCiTiT Aug 23, 2022
fce4e6e
fix version specific repre info in loader
iLLiCiTiT Aug 23, 2022
c393105
use BaseException
iLLiCiTiT Aug 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions openpype/tools/loader/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,11 +272,13 @@ def setData(self, index, value, role=QtCore.Qt.EditRole):

# update availability on active site when version changes
if self.sync_server.enabled and version_doc:
repre_info = self.sync_server.get_repre_info_for_versions(
project_name,
[version_doc["_id"]],
self.active_site,
self.remote_site
repre_info = list(
self.sync_server.get_repre_info_for_versions(
project_name,
[version_doc["_id"]],
self.active_site,
self.remote_site
)
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't next make more sense here since you always just want the first entry?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest I don't like using next for such long expressions especially when it would make it even longer.

repre_info = next(
    self.sync_server.get_repre_info_for_versions(
        project_name,
        [version_doc["_id"]],
        self.active_site,
        self.remote_site
    ),
    None
)

if repre_info:
version_doc["data"].update(
Expand Down