This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Moved functions related to subset names into
openpype.pipeline.create
.Description
Functions
get_subset_name
andget_subset_name_with_asset_doc
inopenpype.lib
are marked as deprecated. Both are calling new function inopenpype.pipeline.create.subset_name
calledget_subset_name
which is copy ofget_subset_name_with_asset_doc
.Additional info
Because
get_subset_name
is not used it was not added to new location at all andget_subset_name_with_asset_doc
was renamed toget_subset_name
. New function can expect project settings to make calculations faster.I moved the logic under "create" category because it is used for instance creation. But it's also used in publish plugins when instances are "auto-created" (which is still technically creation?).
I've named the file
subset_name.py
because I didn't know where elso to put it. I think it's more lib function for creation because at the end subset name is defined by creators. Let comments if you agree with havingsubset_name.py
or use different file. At this moment is content not directly imported so it would be easy to change.Testing notes: