Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

General: Move subset name functionality #3723

Merged
merged 9 commits into from
Aug 26, 2022

Conversation

iLLiCiTiT
Copy link
Member

Brief description

Moved functions related to subset names into openpype.pipeline.create.

Description

Functions get_subset_name and get_subset_name_with_asset_doc in openpype.lib are marked as deprecated. Both are calling new function in openpype.pipeline.create.subset_name called get_subset_name which is copy of get_subset_name_with_asset_doc.

Additional info

Because get_subset_name is not used it was not added to new location at all and get_subset_name_with_asset_doc was renamed to get_subset_name. New function can expect project settings to make calculations faster.

I moved the logic under "create" category because it is used for instance creation. But it's also used in publish plugins when instances are "auto-created" (which is still technically creation?).

I've named the file subset_name.py because I didn't know where elso to put it. I think it's more lib function for creation because at the end subset name is defined by creators. Let comments if you agree with having subset_name.py or use different file. At this moment is content not directly imported so it would be easy to change.

Testing notes:

  1. Creation of instances should work in any host and subset name should be filled correctly.

@ynbot
Copy link
Contributor

ynbot commented Aug 24, 2022

Task linked: OP-3819 Move subset name functionality

@iLLiCiTiT iLLiCiTiT self-assigned this Aug 24, 2022
@iLLiCiTiT iLLiCiTiT added the type: refactor Structural changes not affecting functionality label Aug 24, 2022
Copy link
Member

@64qam 64qam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Nuke, PS, AE

@iLLiCiTiT iLLiCiTiT merged commit 52fdba8 into develop Aug 26, 2022
@iLLiCiTiT iLLiCiTiT deleted the feature/OP-3819_Move-subset-name-functionality branch August 26, 2022 13:00
@BigRoy BigRoy changed the title Genetal: Move subset name functionality General: Move subset name functionality Aug 26, 2022
@BigRoy
Copy link
Collaborator

BigRoy commented Aug 26, 2022

I had to change that PR title because - oh boy - I read that the wrong way.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: refactor Structural changes not affecting functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants