This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Maya + Yeti: Fix yeti cache load using wrong name in edge case #3841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… renaming new node
|
Hi Roy, |
|
Tried out to test it however I have no clue how to get conditions like that :) ...cant get my head around this problem resp how to create such conditions. However when tested at least yeti publish/load Im encountering the same issue as in here #3404 |
LiborBatek
reviewed
Nov 2, 2022
antirotor
approved these changes
Nov 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
We hit this issue when the code was trying to create a group node that by pure luck had a node name that matched exactly with a name that was also in the namespace - thus maya would auto-rename the created group node.
As such
group_name != group_nodeand the.setOutlinerColorfailed to do its job correctly.Description
This fixes it by actually using the node name returned by maya.
Testing notes:
Might be hard to test the specific edge case since I'm not entirely sure how we got the exact name match. But just testing a Yeti publish + load to begin with should be a good test.