This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Publisher: Files Drag n Drop cleanup #3888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It fixed those issues but there is till some confusion here:
I would expect the file dragged to the upper box to be added there, not to replace existing one? |
antirotor
approved these changes
Oct 3, 2022
iLLiCiTiT
deleted the
bugfix/OP-3965_Publisher-draging-files-around-breaks-things
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Cleanup code of files widgets used in publisher.
Description
Handle moving around of items in files widget. Stack widgets in files widget to handle their size hints. Proper showing of empty widget on moving items around. Hide Drag'n'Drop label if user can't drop any.
Additional info
Files widget changed a look when have no items in. The view is painted underneath so the beackground is dark grey.
Screenshot
Testing notes:
Resolves #3837
Resolves #3836