This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Bug: Fixing version detection and filtering in Igniter #3914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antirotor
added
type: bug
64qam
approved these changes
Oct 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix
This PR is fixing logic of detection filtered version compatible with the currently installed build. It is also removing unnecessary and obsolete code.
Note: this already includes #3903 as it was needed for testing.
Testing notes
Same as with #3903
Delete all versions from local app data. Be sure you have no newer version in update repository. Run Igniter and "install" OP. Everything should work.