This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 129
Fusion: Implement callbacks to Fusion's event system thread #3928
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
6d6348f
Fix logging handler to still print logs correctly when original "comp…
BigRoy 6120d3b
Remove unused import
BigRoy 0ebb6bd
Fix missing import
BigRoy e9110d5
Add FusionEventHandler with background QThread
BigRoy fa256ad
Force repair on new comp without asking the user
BigRoy 3239953
Optimize Fusion pulse
BigRoy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,9 +19,12 @@ def run(self): | |
while True: | ||
if self.isInterruptionRequested(): | ||
return | ||
try: | ||
app.Test() | ||
except Exception: | ||
|
||
# We don't need to call Test because PyRemoteObject of the app | ||
# will actually fail to even resolve the Test function if it has | ||
# gone down. So we can actually already just check by confirming | ||
# the method is still getting resolved. (Optimization) | ||
if app.Test is None: | ||
Comment on lines
+22
to
+27
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As comment explains this will mostly result in less delays (since calling |
||
self.no_response.emit() | ||
|
||
self.msleep(interval) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is mostly an optimization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Warning: I've just found that this logic does not work in Fusion 17.2 (released around June 2021) but does work in Fusion 17.4 since the
fusion
instance does not have aPrint
method in the older Fusion.We might need to introduce a fallback to support older fusion versions.