Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

AttributeDefs: Fix crashing multivalue of files widget #3937

Merged
merged 1 commit into from
Oct 7, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions openpype/widgets/attribute_defs/files_widget.py
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,15 @@ def add_filepaths(self, items):
if not items:
return

if self._multivalue:
_items = []
for item in items:
if isinstance(item, (tuple, list, set)):
_items.extend(item)
else:
_items.append(item)
items = _items

file_items = FileDefItem.from_value(items, self._allow_sequences)
if not file_items:
return
Expand Down Expand Up @@ -615,6 +624,7 @@ def __init__(self, *args, **kwargs):
self.customContextMenuRequested.connect(self._on_context_menu_request)

self._remove_btn = remove_btn
self._multivalue = False

def setSelectionModel(self, *args, **kwargs):
"""Catch selection model set to register signal callback.
Expand All @@ -629,12 +639,13 @@ def setSelectionModel(self, *args, **kwargs):
def set_multivalue(self, multivalue):
"""Disable remove button on multivalue."""

self._multivalue = multivalue
self._remove_btn.setVisible(not multivalue)

def update_remove_btn_visibility(self):
model = self.model()
visible = False
if model:
if not self._multivalue and model:
visible = model.rowCount() > 0
self._remove_btn.setVisible(visible)

Expand Down Expand Up @@ -749,12 +760,13 @@ def __init__(self, single_item, allow_sequences, extensions_label, parent):
self._layout = layout

def _set_multivalue(self, multivalue):
if self._multivalue == multivalue:
if self._multivalue is multivalue:
return
self._multivalue = multivalue
self._files_view.set_multivalue(multivalue)
self._files_model.set_multivalue(multivalue)
self._files_proxy_model.set_multivalue(multivalue)
self.setEnabled(not multivalue)

def set_value(self, value, multivalue):
self._in_set_value = True
Expand Down