Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Refactor: changed legacy way to update database for Hero version integrate #3941

Merged
merged 10 commits into from
Oct 11, 2022
Merged

Refactor: changed legacy way to update database for Hero version integrate #3941

merged 10 commits into from
Oct 11, 2022

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Oct 5, 2022 •
edited
Loading

Brief description

Operations used instead.

Testing notes:

  1. I am actually not sure how to test all use cases (with representations, unarchiving them etc), so any steps to test this properly are welcomed
  2. Publish any family that produces Hero version (I have tested in on model).

@kalisp kalisp added the type: enhancement Enhancements to existing functionality label Oct 5, 2022
@kalisp kalisp self-assigned this Oct 5, 2022
@ynbot
Copy link
Contributor

ynbot commented Oct 5, 2022

Task linked: OP-4181 Integrate Hero version using operations

@kalisp kalisp changed the title Client: changed legacy way to update database Refactor: changed legacy way to update database Oct 5, 2022
@BigRoy
Copy link
Collaborator

BigRoy commented Oct 5, 2022

Might be best to update the title of this PR to state that it's only about Hero Versions?

@kalisp kalisp changed the title Refactor: changed legacy way to update database Refactor: changed legacy way to update database for Hero version integrate Oct 5, 2022
iLLiCiTiT
iLLiCiTiT reviewed Oct 5, 2022
View reviewed changes
openpype/client/operations.py Outdated Show resolved Hide resolved
openpype/client/operations.py Outdated Show resolved Hide resolved
@kalisp kalisp requested a review from iLLiCiTiT October 6, 2022 16:07
iLLiCiTiT
iLLiCiTiT approved these changes Oct 7, 2022
View reviewed changes
Copy link
Member

@iLLiCiTiT iLLiCiTiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion but otherwise it works.

@kalisp @iLLiCiTiT
OP-4181 - removed unneeded line
adc5d04 
_id set already higher when item is created.

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
@kalisp kalisp merged commit 46e1c9b into develop Oct 11, 2022
@kalisp kalisp deleted the chore/OP-4181_Integrate-Hero-version-using-operations branch October 11, 2022 09:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iLLiCiTiT iLLiCiTiT iLLiCiTiT approved these changes

@m-u-r-p-h-y m-u-r-p-h-y Awaiting requested review from m-u-r-p-h-y

@64qam 64qam Awaiting requested review from 64qam

Assignees

@kalisp kalisp

Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kalisp @ynbot @BigRoy @iLLiCiTiT