This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Photoshop: make new publisher default #4051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Going further Adobe DCC should switch to new publisher by default, eg. Publisher is not experimental for them anymore.
Updated extension version number
Functionality already in Publisher. Moved list_instances and remove_instances directly into PhotoshopHost (needed for Creators).
Use PhotoshopHost class instead to standardize.
If subset was created with layer name, keep it when renaming.
get_dynamic_data requires instance as positional argument
Ingested into PhotoshopHost
Obsolete, replaced by Publisher
Replaced by Publisher
Manage should trigger Scene Manager, eg. loaded containers
Manage should trigger Scene Manager, eg. loaded containers
|
Task linked: OP-3908 Make New Publisher default in Photoshop |
…ection-loading-not-working-on-matching-representation Loader: Fix comparison of repre name
…P-3908_Make-New-Publisher-default-in-Photoshop
Initialize of PhotoshopHost might be potentially expensive Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Initialization might be expensive, use self.host instead.
iLLiCiTiT
reviewed
Nov 2, 2022
iLLiCiTiT
reviewed
Nov 2, 2022
list_instances could be expensive in larger workfiles, it makes sense to cache it for all creator, but only for collecting phase. (This is why creator.collection_shared_data is used.)
…unction' into feature/OP-3908_Make-New-Publisher-default-in-Photoshop
In between cache function was extracted into creator_plugins, use this to standardize betwen different hosts.
iLLiCiTiT
reviewed
Nov 3, 2022
cached instances are dictionary where keys are creator identifier, eg family.
Standard approach doesn't handle legacy instances, eg. instance without creator_identifier.
iLLiCiTiT
reviewed
Nov 3, 2022
iLLiCiTiT
reviewed
Nov 3, 2022
kalisp
changed the title
64qam
approved these changes
Nov 4, 2022
kalisp
deleted the
feature/OP-3908_Make-New-Publisher-default-in-Photoshop
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Removed old Pyblish and switched to
PublisherDescription
Updated documentation, updated extension menu
Additional info
Needs to redeploy extension!!!
Refactored to new host class to standardize.
Testing notes: