-
Notifications
You must be signed in to change notification settings - Fork 129
Maya: aov filtering #4083
Maya: aov filtering #4083
Conversation
the render settings under |
I find out that the boolean of multipart in |
Task linked: OP-4341 aov filtering |
I have tested it for However I have encountered problems when testing with Repair action sets prefixes like this: I guess this should been already addressed in this PR #3880 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So now it works also in Redshift. Seems ok to me. Not spotted any problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor cosmetic changes
# Any AOVs that still get processed, like Cryptomatte | ||
# by themselves are not multipart files. | ||
aov_multipart = not multipart | ||
# aov_multipart = not multipart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just remove this
if instance_data.get("multipartExr"): | ||
preview = True | ||
|
||
self.log.info("preview:{}".format(preview)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self.log.info("preview:{}".format(preview)) | |
self.log.debug("preview:{}".format(preview)) |
@@ -542,7 +543,7 @@ def _create_instances_for_aov(self, instance_data, exp_files): | |||
if new_instance.get("extendFrames", False): | |||
self._copy_extend_frames(new_instance, rep) | |||
instances.append(new_instance) | |||
|
|||
self.log.info("instances:{}".format(instances)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self.log.info("instances:{}".format(instances)) | |
self.log.debug("instances:{}".format(instances)) |
tested and reviewed by others
Brief description
fixing the bug for the regex filter not excluding the aov in RedShift
See(#4057)
Description
Multipart boolean option of the renderers (RedShift and Arnold) is broken in lib_renderproduct.py, which submits a wrong information to collect_render.py(i.e. multipart is always True even when it is being turned off..), This cause the review option not working with regex filters, which depends on whether multipart is on /off.
For this fix,
if “force combine beauty and AOVs into single file” or “multipart EXR” in Redshift Render Setting is off, it will filter out the renderpass according to the regex filter set in the Openpype Setting. (I set .([Bb]eauty). as filter)
If either one is on, it will show both beauty and Cryptomatte pass.
If mergeAOVs or multipart in Arnold Render Setting is off, it will filter out the renderpass in regards to the regex filter set in the Openpype setting. .
If multipart is on, it will render all the passes for the multipart option (I am not sure if it’s a good idea. so let me know if you also want the filter option included here.)
while it will just only render beauty pass for mergeAOVs
Additional info
No Additional Info
Testing Notes
check if you have disable the "multipart" or "force combine beauty and AOVs" in Redshift Render Setting OR
check if you have disable the "mutlipart" or "Merge AOVs" in Arnold Render Setting.
set your regex filter in deadline setting
add the AOV maps
Create the render instance and run the publisher