Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

bugfix/blender launch refix #41

Merged
merged 1 commit into from
Apr 3, 2020
Merged

Conversation

iLLiCiTiT
Copy link
Member

Fix blender >=2.81 launch:

  • subprocess in app launch is again stored to variable
  • name of variable was changed from popen to _popen
  • added comment why storing to variable is there

@iLLiCiTiT iLLiCiTiT added the type: bug Something isn't working label Apr 3, 2020
@iLLiCiTiT iLLiCiTiT self-assigned this Apr 3, 2020
# Store subprocess to varaible. This is due to Blender launch
# bug. Please make sure Blender >=2.81 can be launched before
# remove `_popen` variable.
_popen = avalonlib.launch(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

local variable '_popen' is assigned to but never used

@mkolar mkolar merged commit eaa179d into develop Apr 3, 2020
@mkolar mkolar deleted the bugfix/blende_launch_refix branch May 13, 2020 21:03
mkolar added a commit that referenced this pull request Apr 5, 2021
Deadline - cleanup, add documentation
kaamaurice referenced this pull request in Tilix4/OpenPype Jan 20, 2023
Feature: Prefill datacol with active object or collection
Decnox pushed a commit to Decnox/OpenPype that referenced this pull request Jun 2, 2023
* create anim instance for animated obj

* optimize with add_datablocks_to_container

* optimize animated_objects set

* instances_to_create using containers

* clear old code

* added collection type to anim instance

* set publish prop for setdress anim instance

* optimized code and comments

* fix if conditions

* fix comment
Decnox pushed a commit to Decnox/OpenPype that referenced this pull request Jun 12, 2023
* create anim instance for animated obj

* optimize with add_datablocks_to_container

* optimize animated_objects set

* instances_to_create using containers

* clear old code

* added collection type to anim instance

* set publish prop for setdress anim instance

* optimized code and comments

* fix if conditions

* fix comment
Decnox pushed a commit to Decnox/OpenPype that referenced this pull request Jun 27, 2023
* create anim instance for animated obj

* optimize with add_datablocks_to_container

* optimize animated_objects set

* instances_to_create using containers

* clear old code

* added collection type to anim instance

* set publish prop for setdress anim instance

* optimized code and comments

* fix if conditions

* fix comment
Sharkitty pushed a commit to Sharkitty/OpenPype that referenced this pull request Jul 28, 2023
* create anim instance for animated obj

* optimize with add_datablocks_to_container

* optimize animated_objects set

* instances_to_create using containers

* clear old code

* added collection type to anim instance

* set publish prop for setdress anim instance

* optimized code and comments

* fix if conditions

* fix comment
Sharkitty pushed a commit to Sharkitty/OpenPype that referenced this pull request Sep 7, 2023
* create anim instance for animated obj

* optimize with add_datablocks_to_container

* optimize animated_objects set

* instances_to_create using containers

* clear old code

* added collection type to anim instance

* set publish prop for setdress anim instance

* optimized code and comments

* fix if conditions

* fix comment
Sharkitty pushed a commit to Sharkitty/OpenPype that referenced this pull request Jan 8, 2024
* create anim instance for animated obj

* optimize with add_datablocks_to_container

* optimize animated_objects set

* instances_to_create using containers

* clear old code

* added collection type to anim instance

* set publish prop for setdress anim instance

* optimized code and comments

* fix if conditions

* fix comment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants