This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Ftrack: Editorial asset sync issue #4126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: OP-4499 Backend - editorial asset sync issue |
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| def import_to_ftrack(self, project_name, input_data, parent=None): | ||
| return output | ||
|
|
||
| def import_to_ftrack(self, project_name, hierarchy_context): |
There was a problem hiding this comment.
'IntegrateHierarchyToFtrack.import_to_ftrack' is too complex (36)
iLLiCiTiT
added
type: enhancement
iLLiCiTiT
deleted the
feature/OP-4499_Backend---editorial-asset-sync-issue
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Probably fixing most of current issue with editorial publishing. Auto sync is not turned off (and back to on) during ftrack hierarchy integration which caused that assets without unavailable entities were marked as archived and at the same time were created new assets which lead to double asset documents and subsets created during editorial publishing lead to the archived one.
Description
Auto sync is not turned on/off. Entities for filling ftrack entities are prequeried for whole project instead of querying all entities separatelly. Custom attributes are "created" or "updated" to table
"CustomAttributeValue"instead of"ContextCustomAttributeValue"(which could cause that entity did not have filled the value as expected. Recursive functions were modified to queu based. Avoid requery of data from ftrack.Additional info
There is still room for improvement in the hierarchy plugin and some change on ftrack event sync but for now this should fix most of current issues.
Testing notes:
Editorial publishing should work the same or better way.