Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Blender: added project settings for validator no colons in name #4149

Conversation

kaamaurice
Copy link
Contributor

Brief description

Added for Blender host : Validator No colons In Name in project settings schemas and defaults.

@kaamaurice kaamaurice changed the title added settings for validator no colons in name Blender: added project settings for validator no colons in name Nov 29, 2022
@LiborBatek LiborBatek self-requested a review December 14, 2022 14:07
@LiborBatek
Copy link
Member

LiborBatek commented Dec 14, 2022

Sry but I cant checkout your branch...could you check whats the issue? I would like to review this PR if still valid. Thx

Note: discussed it with @antirotor and it could be caused by (not)using capital letters in the branch folder so GitKraken which I am using cant check out

@LiborBatek
Copy link
Member

image

Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked with the project settings, looks good for me in terms of the code.
also checked with blender with Openpype. When optional enables, it can allow the validator to be optional
image

@mkolar mkolar merged commit 5fcd177 into ynput:develop Jan 20, 2023
@github-actions github-actions bot added this to the next-patch milestone Jan 20, 2023
@jakubjezek001 jakubjezek001 modified the milestones: next-patch, 3.15.0 Jan 25, 2023
@kaamaurice kaamaurice deleted the enhancement/blender_added-settings-for-validator-no-colons-in-name branch March 7, 2023 13:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants