Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Bugfix: Standalone Publish - ValidateTextureBatchWorkfiles settings #4150

Merged

Conversation

2-REC
Copy link
Contributor

@2-REC 2-REC commented Nov 30, 2022

Brief description

The ValidateTextureBatchWorkfiles plugin of the "Standalone Publish" tool expects an undefined setting for the main workfile extensions.

Description

The class variable main_workfile_extensions is initialised to a specific value (mra), which cannot be overridden as no setting is defined for the plugin.
Additionally, the setting is already defined for the plugin CollectTextures and should thus be reused/shared ("Main workfile extensions"):

project_settings/standalonepublisher/publish/CollectTextures/main_workfile_extensions

Not reusing the same setting creates redundancy and potential issues as different values can then be set.
The ValidateTextureBatchWorkfiles plugin should thus get the setting value set from the CollectTextures plugin.

@2-REC
Copy link
Contributor Author

2-REC commented Nov 30, 2022

NOTE: I am not sure getting the setting from another plugin this way is the best way, as the name of the plugin and setting are hardcoded.

@kalisp kalisp self-requested a review November 30, 2022 15:20
@kalisp
Copy link
Member

kalisp commented Dec 2, 2022

I think its fine, we are using this approach to get plugin settings from different plugin in multiple places.

Just please remove TODO comments and class variable, I don't think having it as a fallback is necessary and I will approve it and merge.

@2-REC
Copy link
Contributor Author

2-REC commented Dec 2, 2022

Just please remove TODO comments and class variable, I don't think having it as a fallback is necessary and I will approve it and merge.

Should we still catch the exception if the setting is missing, or just remove the try/except block?

@kalisp
Copy link
Member

kalisp commented Dec 2, 2022

I would probably catch the exception and manipulate it into something human readable for artists.

@kalisp kalisp merged commit 092ae0f into ynput:develop Dec 5, 2022
@github-actions github-actions bot added this to the next-patch milestone Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants