-
Notifications
You must be signed in to change notification settings - Fork 129
Global: adding imageio to settings #4158
Global: adding imageio to settings #4158
Conversation
so it can be distributed to all hosts
maya, fusion
…global-config-with-mapping-and-file-rules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last): File "/usr/local/bin/flake8", line 8, in sys.exit(main()) File "/usr/local/lib/python3.8/dist-packages/flake8/main/cli.py", line 18, in main app.run(argv) File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 393, in run self._run(argv) File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 381, in _run self.run_checks() File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 300, in run_checks self.file_checker_manager.run() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 331, in run self.run_serial() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 315, in run_serial checker.run_checks() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 598, in run_checks self.run_ast_checks() File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 502, in run_ast_checks for (line_number, offset, text, check) in runner: File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 56, in run parser.visit(self.tree) File "/usr/lib/python3.8/ast.py", line 371, in visit return visitor(node) File "/usr/lib/python3.8/ast.py", line 379, in generic_visit self.visit(item) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 39, in visit_ClassDef self.capture_issues_visitor('ClassDef', node) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 33, in capture_issues_visitor self.generic_visit(node) File "/usr/lib/python3.8/ast.py", line 381, in generic_visit self.visit(value) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 36, in visit_Call self.capture_issues_visitor('Call', node) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 30, in capture_issues_visitor issues = checker.run(node) File "/usr/local/lib/python3.8/dist-packages/flake8_django/checkers/render.py", line 22, in run if isinstance(arg, ast.Call) and arg.func.id == 'locals': AttributeError: 'Attribute' object has no attribute 'id'
|
||
class AEDeadlinePublishTestClass(AEHostFixtures, DeadlinePublishTest): | ||
"""Testing class for Deadline publishes.""" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blank line at end of file
tests/integration/hosts/maya/lib.py
Outdated
|
||
class MayaDeadlinePublishTestClass(MayaHostFixtures, DeadlinePublishTest): | ||
"""Testing class for Deadline publishes.""" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blank line at end of file
tests/integration/hosts/nuke/lib.py
Outdated
|
||
class NukeDeadlinePublishTestClass(NukeHostFixtures, DeadlinePublishTest): | ||
"""Testing class for Deadline publishes.""" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blank line at end of file
…ribution' into feature/OP-4404_color-v3-Settings-global-config-with-mapping-and-file-rules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to make sure it is clear - putting these configs to hosts that doesn't support OCIO is because the config defines rules to transform DCC native colorspace (via arbitrary mapping) to that OCIO config, right @jakubjezek001 ?
Exactly ;) |
cd10b7d
into
feature/OP-2479_color-v3-Colorspace-management-and-distribution
Brief description
ImageIO settings with OCIO config and file rules
Description
Default path is pointing to our distributed aces_1.2 config. File rules are disabled by default as those are usually used on hosts, but times to times we could need to use them for some OIIO conversions on global scope.
Techical notes
This is a first step towards color managed OpenPype. There is at the moment none functionality implemented yet using this settings.
Config and File rules were devaded into separate schemas, because we will need to accompany them to Nuke, Maya, Fusion, Flame to already created ImageIO settings - in future PRs we will replace already created OCIO Config Path in Maya, Nuke, Fusion (read Questions for more info).
Update
Questions
Should the imageio schema be integrated to all hosts?
We had agreed to do so in this PR with @antirotor
What about host which are already having some variant of cutsomOcioConfigPath input? For example Maya is having
project_settings/maya/imageio/colorManagementPreference_v2/configFilePath
and it is used in host api.Depricated label to original schema is signaling future changes and calling for action to migrate to new key
project_settings/{app}/imageio/ocio_config/filepath
Testing notes:
[Nuke, Hiero, Resolve, Maya, Houdini, Blender, Unreal, CelAction, Fusion, Flame, TVPaint, Harmony, Photoshop, AfterEffects, TrayPublisher, WebPublisher]