This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
General: Comment per instance in Publisher #4178
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Instances in publisher can have ability to set comment per instance.
Description
Collect comment plugin also store comment to each instance in context (so all plugins using it can access it directly). Added plugin which define "comment" attribute per instance and have settings for which families is available. By default is disabled and for none families.
The same should work when instance is sent to farm. Comment should stay on instances (didn't test).
Additional information
Modified instance data sent to farm to contain comment per instance to persist comment from UI.
Testing notes:
Collect Comment per instance
in settings and fill families by your choice (project_settings/global/publish/collect_comment_per_instance
)