bugfix/image plane load error

[moonyuet]

Brief description

Fix the image plane load error

Description

Fix the bugs and remove some attributes according to #3256

Additional info

No additional info

Testing notes:

1. Openpype -> Load and select exr sequence
2. right mouse click to load the exrs as image plane sequence
3. create a new camera

[ynbot]

Task linked: OP-3304 Maya: image plane load error

[LiborBatek]

Following the testing steps, it shows this error msg:

however the image sequence get connected to the selected cam (chosen during the loading action co connect imagePlane to my shot cam)

[LiborBatek]

gives me the error even when creating new camera during loading action of imagePlane not trying to attach it to the existing camera (creating new one)

[moonyuet]

gives me the error even when creating new camera during loading action of imagePlane not trying to attach it to the existing camera (creating new one)
I have updated the PR to fix the setAttr issue. This could be because time1 node, which connects to the frameExtension of the image plane, doesn't allow to be deleted in maya. I can only disconnect the nodes instead of deleting it.

[LiborBatek]

The error with frame.extension is not showing anymore so its fixed but there is still other issue with frame offset being wrong set to 1000.

When manually set to correct value (zero) the image sequence being correctly set and visible.

Could be also just an issue in maya2023 not maya2022.
I think its necessary to keep default frame offset at zero value.

[LiborBatek]

Tested it again in maya2022 frame offset being set to 1000 it shows image seq despite the offset value (it shouldnt be visible because of that offset) and behaves differently than in maya2023 were the image seq is not visible as its out of frame range (seq 1001-1005 being offset by another 1000). Seems like maya2022 bug to me which was fixed in maya2023. Anyways I propose to keep/set the offset at zero by defaults. User can offset it manually when needed...

[m-u-r-p-h-y]

@LiborBatek can you check all items mentioned in the original issue #3256

[moonyuet]

Tested it again in maya2022 frame offset being set to 1000 it shows image seq despite the offset value (it shouldnt be visible because of that offset) and behaves differently than in maya2023 were the image seq is not visible as its out of frame range (seq 1001-1005 being offset by another 1000). Seems like maya2022 bug to me which was fixed in maya2023. Anyways I propose to keep/set the offset at zero by defaults. User can offset it manually when needed...

I will remove or set the frameoffset to zero but maybe need to wait because currently i can't really commit to the code and it seems that I dont have the access right to push the latest codes to the PR

[LiborBatek]

Did all tests in maya2022 and maya2023 now all correct. frame offset being kept at zero value. Also tested to load multiple imagePlanes on the same camera and all worked fine.
Went through old PRs to see if anything was not left out for consideration. Seems ok to me.

[m-u-r-p-h-y]

The cancel button is still not working

Traceback (most recent call last):
  File "D:\REPO\OpenPype\openpype\tools\loader\widgets.py", line 1578, in _load_representations_by_loader
    options=options
  File "D:\REPO\OpenPype\openpype\pipeline\load\utils.py", line 299, in load_with_repre_context
    return loader.load(repre_context, name, namespace, options)
  File "D:\REPO\OpenPype\openpype\hosts\maya\plugins\load\load_image_plane.py", line 112, in load
    camera = camera_names[window.camera]
KeyError: None

[m-u-r-p-h-y]

Now there is no error appearing after pressing the Cancel button, but nothing is happening, the dialog is still there.

[moonyuet]

Now there is no error appearing after pressing the Cancel button, but nothing is happening, the dialog is still there.

let's try the simplest way to just close the dialog to see if it can be "closed" by cancel button and also cancel to choose any camera. It is in the updated PR, and it is supposed that the cancelButton can be closed as usual.

[m-u-r-p-h-y]

the Cancel button works now . . . :)

[iLLiCiTiT]

Suggested change

	try:
	camera = camera_names[window.camera]
	except KeyError:
	pass
	# Skip if no camera was selected (Dialog was closed)
	if window.camera not in camera_names:
	return
	camera = camera_names[window.camera]