Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Blender: Workfile Loader #4234

Merged
merged 7 commits into from
Dec 16, 2022
Merged

Conversation

simonebarbieri
Copy link
Contributor

Brief description

Implemented the importer for other blend workfiles.

Description

The workfile importer will import everything from another blend file, but it will not create any container for it. It will just merge the content in the current blend file.

@simonebarbieri simonebarbieri self-assigned this Dec 15, 2022
@simonebarbieri simonebarbieri added host: Blender type: feature Larger, user affecting changes and completely new things labels Dec 15, 2022
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as supposed to without any problem.

@LiborBatek
Copy link
Member

LiborBatek commented Dec 16, 2022

My only concern (not blocking merging of this PR) it would be better to call this function append file not import because blender doesnt provide such operation and it basically is regular append function.

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Necessary to adjust it as discussed together. Which means there will be 2 operation types:
append function (basically as blender which creates another scene in blender file)
import function (just importing workfile into existing blender scene creating new collection of imported objects)
The core function is working now but needs to be enhanced/polished.

@LiborBatek LiborBatek dismissed their stale review December 16, 2022 16:56

already addressed

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been tested both using append workfile and import workfile and both works ok!

@LiborBatek LiborBatek merged commit 6d2e862 into develop Dec 16, 2022
@github-actions github-actions bot added this to the next-patch milestone Dec 16, 2022
@mkolar mkolar deleted the feature/blender-workfile_loader branch January 18, 2023 09:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Blender type: feature Larger, user affecting changes and completely new things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants