Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Igniter: Use qtpy modules instead of Qt #4237

Merged
merged 3 commits into from
Dec 16, 2022

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Dec 16, 2022

Brief description

Replaced usage of Qt.py module with qtpy in igniter.

Testing notes:

Igniter tools should work as usually.

  • Login (to mongo) screen is shown
  • Update dialog is visible

@ynbot
Copy link
Contributor

ynbot commented Dec 16, 2022

Task linked: OP-4654 qtpy in igniter

@iLLiCiTiT iLLiCiTiT self-assigned this Dec 16, 2022
@iLLiCiTiT iLLiCiTiT added the type: refactor Structural changes not affecting functionality label Dec 16, 2022
@64qam
Copy link
Member

64qam commented Dec 16, 2022

After the login to mongo:

--- launching setup UI ...
Traceback (most recent call last):
  File "C:\Users\qam\pypeclub\OpenPype\igniter\install_dialog.py", line 351, in _on_run_btn_click
    self._run_openpype()
  File "C:\Users\qam\pypeclub\OpenPype\igniter\install_dialog.py", line 378, in _run_openpype
    install_thread = InstallThread(self)
  File "C:\Users\qam\pypeclub\OpenPype\igniter\install_thread.py", line 38, in __init__
    super().__init__(self, parent)
TypeError: QThread() takes at most 1 argument (2 given)

@iLLiCiTiT
Copy link
Member Author

After the login to mongo:

Should be fixed

@iLLiCiTiT iLLiCiTiT merged commit f803d4a into release/3.15.x Dec 16, 2022
@iLLiCiTiT iLLiCiTiT deleted the feature/OP-4654_qtpy-in-igniter branch December 16, 2022 16:56
@github-actions github-actions bot added this to the next-minor milestone Dec 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: refactor Structural changes not affecting functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants