Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Hiero: Use qtpy in Hiero #4240

Merged
merged 2 commits into from
Dec 19, 2022
Merged

Hiero: Use qtpy in Hiero #4240

merged 2 commits into from
Dec 19, 2022

Conversation

iLLiCiTiT
Copy link
Member

Brief description

Use qtpy in hiero host implementation instead of Qt.py.

Additional information

This PR does not change usage in host tools just imports used inside host implementation.

Testing notes:

Hiero UIs should work as did before (even in older then 13.*).

@ynbot
Copy link
Contributor

ynbot commented Dec 16, 2022

Task linked: OP-4657 qtpy in hiero

@iLLiCiTiT iLLiCiTiT self-assigned this Dec 16, 2022
@iLLiCiTiT iLLiCiTiT added host: Hiero type: refactor Structural changes not affecting functionality labels Dec 16, 2022
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  File "C:\Program Files\Nuke12.2v3\pythonextensions\site-packages\hiero\core\find_plugins.py", line 53, in loadPluginsFromFolder
    module = __import__( packageName )
  File "C:/CODE/__PYPE/OpenPype/openpype/hosts/hiero/api/startup\Python\StartupUI\otioimporter\__init__.py", line 12, in <module>
    from openpype.hosts.hiero.api.otio.hiero_import import load_otio
  File "C:\CODE\__PYPE\OpenPype\openpype\hosts\hiero\api\__init__.py", line 10, in <module>
    from .pipeline import (
  File "C:\CODE\__PYPE\OpenPype\openpype\hosts\hiero\api\pipeline.py", line 20, in <module>
    from . import lib, menu, events
  File "C:\CODE\__PYPE\OpenPype\openpype\hosts\hiero\api\lib.py", line 18, in <module>
    from qtpy import QtWidgets, QtCore, QtXml
ImportError: cannot import name QtXml```

@iLLiCiTiT
Copy link
Member Author

I hope Nuke 14 is still using PySide2.

Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PySide2 is the version for Nuke 14 so don't worry ;)

@iLLiCiTiT iLLiCiTiT merged commit 45c26f3 into develop Dec 19, 2022
@iLLiCiTiT iLLiCiTiT deleted the feature/OP-4657_qtpy-in-hiero branch December 19, 2022 21:05
@github-actions github-actions bot added this to the next-patch milestone Dec 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Hiero type: refactor Structural changes not affecting functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants