Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Maya: Use qtpy in Maya #4250

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Maya: Use qtpy in Maya #4250

merged 1 commit into from
Dec 21, 2022

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Dec 20, 2022 •
edited
Loading

Brief description

Use qtpy in maya host implementation instead of Qt.py.

Additional information

This PR does not change usage in host tools just imports used inside host implementation.

Testing notes:

Maya UIs should work as did before (even in Maya 2020).

@ynbot
Copy link
Contributor

ynbot commented Dec 20, 2022

Task linked: OP-4658 qtpy in maya

@iLLiCiTiT iLLiCiTiT changed the title Maya: Use qtpy in Hiero Maya: Use qtpy in Maya Dec 20, 2022
@iLLiCiTiT iLLiCiTiT self-assigned this Dec 20, 2022
@iLLiCiTiT iLLiCiTiT added host: Maya type: refactor Structural changes not affecting functionality labels Dec 20, 2022
m-u-r-p-h-y
m-u-r-p-h-y approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is only about loading OP menu and tools it works in all major Maya versions

image

@BigRoy
Copy link
Collaborator

BigRoy commented Dec 21, 2022

I believe it would also be for the "Scene has outdated content" popup that you get when opening a scene containing versions which are not the latest version.
It would also be good to double check things like the Workfile save version pop-up and right click in the Loader to load something.

Also double check the Look Assigner in maya maybe? (or isn't that influenced by changes in this PR?)

@iLLiCiTiT
Copy link
Member Author

Also double check the Look Assigner in maya maybe? (or isn't that influenced by changes in this PR?)

Nope. Not yet. That will be big PR affecting all hosts. This is just for maya inner implementation.

antirotor
antirotor approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested all in Maya 2020 (py2) and Maya 2023 (py3), all dialogs I could produce, everything is working fine

@antirotor antirotor merged commit 89166a6 into develop Dec 21, 2022
@antirotor antirotor deleted the feature/OP-4658_qtpy-in-maya branch December 21, 2022 10:00
@github-actions github-actions bot added this to the next-patch milestone Dec 21, 2022
@BigRoy BigRoy mentioned this pull request Mar 15, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@m-u-r-p-h-y m-u-r-p-h-y m-u-r-p-h-y approved these changes

@antirotor antirotor antirotor approved these changes

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
host: Maya type: refactor Structural changes not affecting functionality
Projects
None yet
Milestone
3.14.10
Development

Successfully merging this pull request may close these issues.
5 participants
@iLLiCiTiT @ynbot @BigRoy @m-u-r-p-h-y @antirotor