Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

General: Use class constants of QMessageBox #4332

Merged
merged 1 commit into from
Jan 17, 2023
Merged

General: Use class constants of QMessageBox #4332

merged 1 commit into from
Jan 17, 2023

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Jan 17, 2023 •
edited
Loading

Brief description

PR fixing usage of constants with QMessageBox with combination with PySide6 (where constants are not available on objects).

Testing notes:

  1. Use workfiles tool where is save changes prompt that crashed
  2. This dialog is shown if there are unsaved changes in host
  3. The dialog should show and should be possible to select what should happen

Missed that bug in #4255 . There still can be more wrong usage of constants in the code, any reports welcomed.

@iLLiCiTiT iLLiCiTiT self-assigned this Jan 17, 2023
@iLLiCiTiT iLLiCiTiT added the type: bug Something isn't working label Jan 17, 2023
kalisp
kalisp approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works (in Workfile)

@iLLiCiTiT iLLiCiTiT merged commit 0563f84 into release/3.15.x Jan 17, 2023
@iLLiCiTiT iLLiCiTiT deleted the bugfix/pyside6_more_constants branch January 17, 2023 16:05
@github-actions github-actions bot added this to the next-minor milestone Jan 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kalisp kalisp kalisp approved these changes

@64qam 64qam Awaiting requested review from 64qam

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
type: bug Something isn't working
Projects
None yet
Milestone
3.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@iLLiCiTiT @kalisp