Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Global: Validate unique subsets #4336

Merged
merged 4 commits into from
Jan 20, 2023

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Jan 17, 2023

Brief description

This implements a global validator whether the current publish will publish unique subsets (per asset).

This fixes #4330

Additional info

I've removed seemingly equivalent ones from Maya, Fusion and Photoshop - please double check.
There also appeared to be something relatively similar for Maya:

It would be good to know whether there are any cases where this logic doesn't make sense. Would we ever allow a single publish have multiple instances set to the same asset+subset. Can we think of a reason?

Testing notes:

I've only done a quick test in Maya.

  1. Create some instances that publish to the same asset and subset names. (This should be invalidated!)
  2. Create some instances that publish to different asset but match in subset names. (This should be allowed)
  3. Create some instances that publish to same asset but differ in subset names. (This should be allowed)
  4. Create some instances that publish to the same asset and subset names but during publishing deactive/disable the clashing ones. (This should be allowed)

@BigRoy BigRoy self-assigned this Jan 17, 2023
Copy link
Member

@mkolar mkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes good sense to me. I can't think of a scenario where it would be desirable to publish multiple instances into a same subset from one workfile.

@BigRoy
Copy link
Collaborator Author

BigRoy commented Jan 19, 2023

I can't think of a scenario where it would be desirable to publish multiple instances into a same subset from one workfile.

Note that technically we're also talking about publishing from standalone publisher instead of 'a workfile' - not sure if that conceptually changes anything about potentially publishing into the same subset from separate instances?

Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was testing on Nuke 12/13 at new and old publisher and all went smooth.

@mkolar mkolar merged commit 4d567c0 into ynput:develop Jan 20, 2023
@github-actions github-actions bot added this to the next-patch milestone Jan 20, 2023
@jakubjezek001 jakubjezek001 modified the milestones: next-patch, 3.15.0 Jan 25, 2023
@BigRoy BigRoy deleted the global_validate_unique_subsets branch March 20, 2024 15:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global subset name unique validator publish plugin
3 participants